feat!: use Uint8Array in alphabet() and radix#50
Draft
ChALkeR wants to merge 3 commits intopaulmillr:mainfrom
Draft
feat!: use Uint8Array in alphabet() and radix#50ChALkeR wants to merge 3 commits intopaulmillr:mainfrom
ChALkeR wants to merge 3 commits intopaulmillr:mainfrom
Conversation
ChALkeR
force-pushed
the
chalker/uint8/0
branch
from
89d0939 to
d19258f
Compare
Owner
|
seems like 2-2.5x boost on 1mb |
ChALkeR
force-pushed
the
chalker/uint8/0
branch
from
d19258f to
7c6de0a
Compare
This was referenced Oct 14, 2025
ChALkeR
commented
Oct 14, 2025
| // carry overflows here | ||
| t(35195299949887); | ||
| throws(() => t(35195299949887 + 1)); | ||
| throws(() => t(2 ** i)); |
Contributor
Author
There was a problem hiding this comment.
this was a mistake, it threw because i was not defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This limits radix methods to 8-bit max
This is a breaking change
No high-level methods depend on that though (i.e. no base512 etc)
This also switches bech to uint8 words instead of array
It does only a ~5-30% performance improvement, mostly due to this still operating on arrays in
joinI decided to file this first though to make changes more atomic
Unifying
join,padding, andalphabetinto a single method would solve thisBefore:
After: